search

errata-ai / vale-action

:octocat: The official GitHub Action for Vale -- install, manage, and run Vale with ease.
MIT License
201 stars 51 forks source link

check fails when it shouldn't (no vale errors, not supposed to fail on error) #106

Open andie787 opened 1 year ago

andie787 commented 1 year ago

Even if all vale rules are set to suggestion, and fail on error is false, reviewdog logs everything as ERROR and the check fails with reporter github-check-pr.

Can you set the reviewdog error level in this action or do you need a different config file?

UPDATE: what I'm noticing is that my custom rules are running fine and output INFO level logs, the non-custom rule violations (from proselint and Google for example) output ERROR level and cause the check to fail

jdkato commented 1 year ago

Even if all vale rules are set to suggestion,

Are you also setting the "non-custom" rules to suggestion?

andie787 commented 1 year ago

Yes, everything was set to suggestion to try to ease into things