errata-ai / vale-action

:octocat: The official GitHub Action for Vale -- install, manage, and run Vale with ease.
MIT License
201 stars 51 forks source link

Action didn't fail for configuration error in `.yml` files #97

Closed kayx23 closed 1 month ago

kayx23 commented 1 year ago

Noticed reviewdog would pass in the following situations, where I think it should fail.

Example 1

image

image

Link to the action

Example 2

Here I copy pasted the .yml config over and did not notice the incorrect indentation from line 2 and onwards. Reviewdog seems to pass but in reality it errored out: image

Link to the action

rmoff commented 1 month ago

Adding another example of this problem. My vale config had the wrong case for a styles folder. The action still returned a success status though.

CleanShot 2024-10-02 at 09 53 14

CleanShot 2024-10-02 at 09 53 03