errata-ai / vale-ls

:zap: An implementation of the Language Server Protocol (LSP) for the Vale command-line tool.
MIT License
62 stars 4 forks source link

Does the language server support spelling rules #15

Closed ChrisChinchilla closed 1 month ago

ChrisChinchilla commented 1 month ago

Kind of referencing this too : https://github.com/errata-ai/LSP-vale-ls/issues/3

I now have all rules working with quickfix in VSCode extension, but spelling rules don't return a quick fix? Should the language server do that? And if so, what dictionary is it using by default?

jdkato commented 1 month ago

Yes, it does. The dictionary is determined by the rule -- if it specifies a custom one, then that is used. Otherwise, the default is used.

ChrisChinchilla commented 1 month ago

Hmm, interesting, then I wonder why I can't get it to show anything 🤔 . Will investigate.

ChrisChinchilla commented 1 month ago

I can't even get the spelling quick fix to register in the Sublime extension. I wonder, is there some configuration or rule error I should check for? I am using the same rules that work in the current VSCode extension, this rule: https://github.com/ChrisChinchilla/Openly/blob/main/Openly/Spelling.yml that's using an npm package dictionary.

I wonder if somehow I deleted a dictionary file or something, but I don't see any errors.

ChrisChinchilla commented 1 month ago

I found that somehow I had modified a rule, and this now works.