errata-ai / vale-vscode

A Visual Studio Code extension for the Vale CLI.
https://marketplace.visualstudio.com/items?itemName=errata-ai.vale-server
MIT License
53 stars 18 forks source link

Vale problem output in VS Code does not match CLI, despite being set to use CLI #62

Open stewartadam opened 2 years ago

stewartadam commented 2 years ago

After installing VS Code and configuring a .vale.ini in the repo root, the output of vale . and the problems highlighted by the editor are different. Namely, the problems from styles (Microsoft's in this case) are not included in the problem highlights.

jdkato commented 2 years ago

Is this true for individual files?

The command vale . will show alerts for the entire directory, while the extension only shows them for open files.

stewartadam commented 2 years ago

You're right, looks like this is a UX issue around native VSCode functionality and how I expected the extension to operate.

Problem reports within the file are accurately reported in full, however unchecking "Show active file only" in the filters continues to only show problem reports for the current file, not the full output for all files that vale . shows as I was expecting: image

ChrisChinchilla commented 2 years ago

Is the suggestion here to change the extension docs I guess?

stewartadam commented 2 years ago

I guess it depends if we want to consider this bugfix (adjust the docs, preserve current behavior) or a feature request (ensure problem output matches the same as running vale in the workspace, not the current file).