search

errata-ai / vale-vscode

A Visual Studio Code extension for the Vale CLI.
https://marketplace.visualstudio.com/items?itemName=errata-ai.vale-server
MIT License
53 stars 18 forks source link

[To look first]Align VS Code engine version with @types/vscode #83

Closed apupier closed 2 years ago

apupier commented 2 years ago

fixes #82

it allows to fix the build of the master branch.

ChrisChinchilla commented 2 years ago

@apupier I think #78 will do the same, but will merge this one too anyway, thanks!

apupier commented 2 years ago

I think #78 will do the same, but will merge this one too anyway, thanks!

not sure. For now, the vs code engine is still at 1.43.0 and @types/vscode is using 1.69.0. This is detected only with vsce package, not when doing a "simple" compilation such as npm run compile.