search

errata-ai / vale-vscode

A Visual Studio Code extension for the Vale CLI.
https://marketplace.visualstudio.com/items?itemName=errata-ai.vale-server
MIT License
53 stars 18 forks source link

vsUtils.ts: `vale.valeCLI` used for 1 setting, and `vale.valeCLI` has consts for settings under `vale.valeCLI`. #95

Closed rainecheck closed 2 years ago

rainecheck commented 2 years ago

minAlertLevel triggers based on the setting vale.valeCLI.minAlertLevel, but the docs specify it as vale.minAlertLevel. In addition, there are consts for vale.valeCLI for both config and path, and in the docs are specified as vale.{config,path}.

Changing my settings to "vale.valeCLI.minAlertLevel": "suggestion", makes the extension work, even though VS Code thinks it shouldn't.

Uncertain whether this should be fixed by standardising the extension to vale.<setting> or vale.valeCLI.<setting>, but either way this could be a breaking change to people's configs.