DiscordBackend.on_ready should send a callback of some sort

errbotio / err-backend-discord

Backend for Discord for Errbot

GNU General Public License v3.0

23 stars 21 forks source link

DiscordBackend.on_ready should send a callback of some sort #16

Closed shuhaowu closed 5 years ago

shuhaowu commented 6 years ago

Not sure if this goes with the Errbot spec, but it would be nice to send a callback for when the bot joined all the channels. Otherwise sending a message to some channel/person might result in a silent failure.

shuhaowu commented 6 years ago

I did a change to https://github.com/shuhaowu/err-backend-discord/commit/43fcb411c5850a5c8adeb7fc9772e72a2dd51572, but don't have the time to put a proper PR at the moment.

Djiit commented 6 years ago

For the Errbot spec part, I leave it to @gbin. When you do have some time, i'll be happy to review your PR. Thanks !

nzlosh commented 5 years ago

This has been fixed in commit https://github.com/gbin/err-backend-discord/commit/9d6e30d6c860d434fdb4574f4f71f8c3ac82f1b2