search

errbotio / err-backend-discord

Backend for Discord for Errbot
GNU General Public License v3.0
23 stars 22 forks source link

Require mainainer? #20

Closed nzlosh closed 5 years ago

nzlosh commented 5 years ago

What's the status of this repository?

I saw that @Josh-00FF00 is actively patching a fork. @Josh-00FF00 Are you planning to push upstream?

Josh-00FF00 commented 5 years ago

I'd be happy to, although it's quite hacked together currently and quite a large rewrite to get the new discord API working. I'll clean it up some and submit a pull request sometime soon (tm)

nzlosh commented 5 years ago

I'd also like to contribute. I've merged most of your changes into my own repo so I can apply fixes as I encounter issues. If we were able to collaborate via the official repo that would be ideal. @gbin what's required to become a collaborator for this repo?

gbin commented 5 years ago

Np I put you maintainer of the project on the official repo.

gbin commented 5 years ago

We can also move it to errbot io too?

Josh-00FF00 commented 5 years ago

We can also move it to errbot io too?

Not sure I follow, you mean the main errbot repo at https://github.com/errbotio/errbot ?

gbin commented 5 years ago

I mean moving this repo to the errbotio org :)

nzlosh commented 5 years ago

Thank you very much @gbin. I'd be fine with moving it to errbot io, but would this make the backend part of the core backends deployed? If it's the case, it would be best to wait until we've got unit tests and a fully functional backend.

nzlosh commented 5 years ago

@Josh-00FF00 would you mind merging your fork into a development branch on this repo so we can start working together to update the backend?

Josh-00FF00 commented 5 years ago

Don't seem to have write access to create branches here, could you create the develop branch and I'll submit a pull request?

nzlosh commented 5 years ago

OK, I've setup a development branch that we can work in. https://github.com/gbin/err-backend-discord/tree/development

nzlosh commented 5 years ago

@Josh-00FF00 are you on the errbot gitter channel? It would be good to be able to exchange via instant message.

Josh-00FF00 commented 5 years ago

Just joined @nzlosh

nzlosh commented 5 years ago

Great! I'll close this issue and we can discuss things via gitter