errbotio / err-backend-discord

Backend for Discord for Errbot
GNU General Public License v3.0
23 stars 21 forks source link

Known Issues? #5

Closed btotharye closed 7 years ago

btotharye commented 7 years ago

There any known issues with this repo? I"m going to look through the code but when initially setting up the bot is online but when I send !help through to it I'm getting the following:

14:12:11 ERROR    errbot.core               An error happened while processing a message ("!help"): Traceback (most recentcall last):
  File "/usr/local/lib/python3.5/dist-packages/errbot/core.py", line 461, in _execute_and_send
    self.send_simple_reply(msg, self.process_template(template_name, reply), private, threaded)
  File "/usr/local/lib/python3.5/dist-packages/errbot/core.py", line 198, in send_simple_reply
    reply = self.build_reply(msg, text, private=private, threaded=threaded)
TypeError: build_reply() got an unexpected keyword argument 'threaded'
"
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/errbot/core.py", line 461, in _execute_and_send
    self.send_simple_reply(msg, self.process_template(template_name, reply), private, threaded)
  File "/usr/local/lib/python3.5/dist-packages/errbot/core.py", line 198, in send_simple_reply
    reply = self.build_reply(msg, text, private=private, threaded=threaded)
TypeError: build_reply() got an unexpected keyword argument 'threaded'
gbin commented 7 years ago

Ha it needs to be updated for errbot 5.x. If you are game for a PR, this is just the new contract for threaded responses, maybe first add the parameter and ignore it so it runs then maybe implement it if discord supports it.

btotharye commented 7 years ago

Yea I just see what it was as well I'm updating it now

btotharye commented 7 years ago

do you have an example of how this should look by chance from another backend?

btotharye commented 7 years ago

https://github.com/btotharye/err-backend-discord/tree/fix_threading seems to be working atm btw

btotharye commented 7 years ago

also how should the formatting be for the bot admin on this? So far the username or number of the username doesn't seem to be working that I'm getting from the logs.

btotharye commented 7 years ago

nvm looks like its some really long unique ID you have to use from the logs

btotharye commented 7 years ago

ok all good and working

image