search

errbotio / errbot

Errbot is a chatbot, a daemon that connects to your favorite chat service and bring your tools and some fun into the conversation.
http://errbot.io
GNU General Public License v3.0
3.12k stars 614 forks source link

WIP - Markdown v3 support #1418

Closed nzlosh closed 3 years ago

nzlosh commented 4 years ago

Replace deprecated methods and arguments with v3 methods and arguments.

nzlosh commented 4 years ago

@sijis tox passes with this but I'm not entirely clear on the priority values given for the markdown extensions. They seem to work based on Slack and Discord backends.

sijis commented 4 years ago

@sijis tox passes with this but I'm not entirely clear on the priority values given for the markdown extensions. They seem to work based on Slack and Discord backends.

I don't understand the priorities fully myself.

There is a !render_test command that can be used to test the markdown output in those backends.

nzlosh commented 4 years ago

The latest change produces a render test that works for Slack but Mattermost and Discord continue to render </br> in the Markdown extra (table multiline) section.

sijis commented 4 years ago

Would you be able to post an image, so I could visualize the difference?

nzlosh commented 4 years ago

Here's the rendering

Discord (Ignore the blue highlighted text, that was me copy/pasting) discord_render

Mattermost mattermost_render

Slack slack_render

sijis commented 4 years ago

I see what you mean now. I'm finding the markdown library confusing.

The options I keep thinking about are: