Add identifier for callbacks room join and room leave

errbotio / errbot

Errbot is a chatbot, a daemon that connects to your favorite chat service and bring your tools and some fun into the conversation.

http://errbot.io

GNU General Public License v3.0

3.12k stars 614 forks source link

Add identifier for callbacks room join and room leave #1500

Closed duhow closed 3 years ago

duhow commented 3 years ago

Enable to use callback_room_joined and callback_room_left with other identities (Persons), rather than the bot itself only. Not sure if this is a breaking change, currently testing with Slack Events Backend (custom).

duhow commented 3 years ago

I'm thinking if I should just change Room to RoomOccupant, instead of adding new params. @sijis let me know your concerns.

sijis commented 3 years ago

@duhow Thank you for your work. I rebased and made some minor commits to get this mergeable.

@nzlosh - fyi callback could be useful for the v3 backend.