search

errbotio / errbot

Errbot is a chatbot, a daemon that connects to your favorite chat service and bring your tools and some fun into the conversation.
http://errbot.io
GNU General Public License v3.0
3.12k stars 614 forks source link

Fix success handling for update_repos #1520

Closed bboe closed 3 years ago

bboe commented 3 years ago

As part of the switch to python git, the success case handling was reversed even though 0 was still meant to indicate success (formerly used to represent process exited without error).

https://github.com/errbotio/errbot/commit/89bce02a836fdbf14f184ad54e3f9eb1a7becbb1#diff-b279f20d61152a2a99689009a59d70609c92039568c203da8c84bb56ceacd94fR287

This pull request fixes that issue and makes the code a bit more clear by using booleans rather than integers to represent the success state.

sijis commented 3 years ago

Thank you!