search

errbotio / errbot

Errbot is a chatbot, a daemon that connects to your favorite chat service and bring your tools and some fun into the conversation.
http://errbot.io
GNU General Public License v3.0
3.12k stars 614 forks source link

Reload all repo plugins when updating a repo #1521

Closed bboe closed 3 years ago

bboe commented 3 years ago

get_plugin_by_path would only return the first plugin encountered in a repository. This change adds the method get_plugins_by_path which yields plugins as they are found.

For backwards compatibility, I have not deleted the original get_plugin_by_path method, lest anyone use that method directly outside of this package.

sijis commented 3 years ago

Is this reloading all the plugins found in a specific repo or is it reloading all the plugins loaded in errbot?

bboe commented 3 years ago

Just the ones in a specific repository

sijis commented 3 years ago

So in this scenario, a repo has multiple plugins in it, correct?

bboe commented 3 years ago

So in this scenario, a repo has multiple plugins in it, correct?

Yes, that's correct. In my case, multiple .plug files in the root of the repository.

sijis commented 3 years ago

Thank you for these fixes.