search

errbotio / errbot

Errbot is a chatbot, a daemon that connects to your favorite chat service and bring your tools and some fun into the conversation.
http://errbot.io
GNU General Public License v3.0
3.12k stars 612 forks source link

Add get_acl_room support #1550

Closed nzlosh closed 2 years ago

nzlosh commented 2 years ago

This PR is to use the aclattr for Room objects when available. If the aclattr is unavilable, the default behaviour is maintained by return the string representation of the Room object.

This patch is required by https://github.com/errbotio/err-backend-slackv3/pull/62

nzlosh commented 2 years ago

@sijis I've pinned dulwich v0.20.28 because .29 and .30 raise the exception No git repository was found at https://github.com/errbotio/err-helloworld'. I haven't looked into what's changed, if it's a bug in the dulwich module or if the errbot calling code needs to be updated.

nzlosh commented 2 years ago

I've created an issue to track this problem https://github.com/errbotio/errbot/issues/1551

nzlosh commented 2 years ago

upstream issue here https://github.com/dulwich/dulwich/issues/920

nzlosh commented 2 years ago

I closed this PR because it's a duplicate of https://github.com/errbotio/errbot/pull/1530