errbotio / errbot

Errbot is a chatbot, a daemon that connects to your favorite chat service and bring your tools and some fun into the conversation.
http://errbot.io
GNU General Public License v3.0
3.12k stars 612 forks source link

Remove unsupport argument reconnection_interval from irc backend. #1568

Closed nzlosh closed 2 years ago

nzlosh commented 2 years ago

Fixes #1566

sijis commented 2 years ago

So with this, I would need to adjust the pinned dependency for it in https://github.com/errbotio/errbot/blob/89ccd004758843cfb8330461f068d9e849fb70f8/setup.py#L112?

nzlosh commented 2 years ago

Sorry, I didn't explain this PR well. This patch is to make the irc backend compatible with irc==20.0.0 which removed reconnection_interval as an argument. https://github.com/jaraco/irc/blob/main/CHANGES.rst#v2000. So there's no need to adjust pinning, as it's already set to v20