Get plugin activation order from plugins excluding unwanted core plugins

errbotio / errbot

Errbot is a chatbot, a daemon that connects to your favorite chat service and bring your tools and some fun into the conversation.

http://errbot.io

GNU General Public License v3.0

3.09k stars 608 forks source link

Get plugin activation order from plugins excluding unwanted core plugins #1601

Closed ostracon closed 5 months ago

ostracon commented 1 year ago

Small change to get_plugins_activation_order, which should result in errbot properly honouring the CORE_PLUGINS config directive, which I believe is causing the issue outlined in #1591.

ostracon commented 1 year ago

Updated/refactored to fix the issue while still passing all tests.

deborahgu commented 1 year ago

FWIW this fix works, and I have it hacked in manually, and hope it is merged eventually.

kayman-mk commented 9 months ago

Can we get this merged please 🙏

sijis commented 5 months ago

@ostracon Thank you for the fix. I added a few commits to have linting pass.

@tkratky I appreciate your PR provided a sample config to help me fully understand what this was addressing.

@deborahgu and @kayman-mk thank for your patience on waiting for this to be merged.