search

errbotio / errbot

Errbot is a chatbot, a daemon that connects to your favorite chat service and bring your tools and some fun into the conversation.
http://errbot.io
GNU General Public License v3.0
3.13k stars 616 forks source link

Make XMPP backend implement disconnect_callback #176

Closed davidrizzuto closed 11 years ago

davidrizzuto commented 11 years ago

Currently the XMPP backend doesn't call the disconnect_callback.

I'm running 2.0.0-beta, using the hipchat backend. If the bot times out or otherwise disconnects, sleekxmpp will retry the connection, and the XMPP backend doesn't listen for the 'disconnection' event from sleekxmpp

davidrizzuto commented 11 years ago

I've got a quick solution for this I think

davidrizzuto commented 11 years ago

Never mind, seems it was already fixed on master here b3b2fa8d5afaa4a659894d116e54a267341e5cc2.

Closing :)

lkraav commented 11 years ago

Yes, I also made the mistake of patching 2.0.0-beta, only to later discover it had already been taken care of in master. There should be a big red warning sign not to bother with 2.0.0-beta anymore, or release 2.0.0-delta or something.

davidrizzuto commented 11 years ago

Any idea when a new release is expected? I'd rather not have to custom build/package from master to get this into production.

gbin commented 11 years ago

Hi,

I would like to fix the incorrect shutdown of rocket before making a release candidate. It is the reason why unit tests are failing on travis.

I am a little underwater this week, anybody feels courageous to look at it to speed up the process ?

zoni commented 11 years ago

I was actually looking at this issue last weekend, but didn't have enough time to get to the bottom of it. I will leave a note on #175.

I might get a chance this weekend to dig into it further.