errbotio / errbot

Errbot is a chatbot, a daemon that connects to your favorite chat service and bring your tools and some fun into the conversation.
http://errbot.io
GNU General Public License v3.0
3.14k stars 615 forks source link

Error while installing err-gitbot plugin #18

Closed apophys closed 12 years ago

apophys commented 12 years ago

Hello, I've been experimenting with err bot a little and found this odd error.

After "correct installation" of this plugin:

[00:11:38] <me> !install err-gitbot
[00:11:38] <bot JID> A new plugin repository named err-gitbot has been installed correctly from git://github.com/gbin/err-gitbot.git. Refreshing the plugins commands...
[00:11:38] <bot JID> Plugin reload done.

This is what has been logged. Apparently, plugin does not work.

2012-06-29 00:11:38,039 INFO received command = install matching [install] with parameters [err-gitbot]
2012-06-29 00:11:38,961 WARNING Unable to execute the code in plugin: /tmp/err/plugins/err-gitbot/gitBot
2012-06-29 00:11:38,961 INFO Activating all the plugins...

However, err-gitbot repository has been cloned correctly. Also, with err-gitbot in plugins folder, this is what happened after restarting the bot (first two lines of the log):

2012-06-29 00:02:35,068 WARNING Unable to execute the code in plugin: /tmp/err/plugins/err-gitbot/gitBot
2012-06-29 00:02:35,069 INFO Start Connection ...........

I tried to trace this warning. However, I wasn't able to find where is this warning logged and what caused this error. I tried to install err-stalkerbot and err-calcbot and no such errors occured in those cases.

Env: Python 2.7.3, dependencies installed by pip into separated virtualenv, OS X 10.6.8

The same error is occuring on up-to-date (28. 6. 2012) Arch Linux, python 2.7.3

gbin commented 12 years ago

I do not reproduce it here, can you try to : BOT_LOG_LEVEL = logging.DEBUG

and see what yapsy is telling you ? (I reported the issue of this half silent failure upstream btw) It is probably a dependency missing.

apophys commented 12 years ago

Error is caused by a missing dependency. gittools module within err-gitbot imports git package missing in my environment.

I've installed GitPython module. Then :

[09:52:44] <me> !git follow git://github.com/gbin/err.git
[09:52:47] <bot JID> Computer says nooo. See logs for details.:

'GitBot' object has no attribute 'following'

Log: https://gist.github.com/3016562

Following bot response from MUC: https://gist.github.com/3016581

gbin commented 12 years ago

I addressed the first issue at a higher level: since 377f8304445db301bef138df6e800a933810b2e2 err will check if a plugin repo has a standard requirements.txt and will warn the admin / yell in the log if a dependency is missing. I am looking for the second issue.

gbin commented 12 years ago

moved this issue to the gitbot plugin https://github.com/gbin/err-gitbot/issues/1