search

errbotio / errbot

Errbot is a chatbot, a daemon that connects to your favorite chat service and bring your tools and some fun into the conversation.
http://errbot.io
GNU General Public License v3.0
3.09k stars 608 forks source link

IRC backend doesn't render cards correctly #803

Open harlowja opened 8 years ago

harlowja commented 8 years ago

Not everyone uses mIRC so we shouldn't default to the format that only works with it (because thats not exactly a friendly output for other IRC client users),

For example here is a output from hexchat:

<gerritbot2>  {: color='black' bgcolor='green' }
<gerritbot2> Kyrylo Galanov (kgalanov@mirantis.com) proposed change Fix race condition in get puppet status at https://review.openstack.org/335319 in project openstack/fuel-astute (+1|-1).
<gerritbot2>    ()
gbin commented 8 years ago

hmmm it doesn't look like mIRC color codes, is this a template that somehow doesn't work ?

harlowja commented 8 years ago

Template is @ https://github.com/harlowja/gerritbot2/blob/master/plugins/gerritbot/templates/proposal.md so I don't think so.

gbin commented 8 years ago

Maybe this is coming from a card before this message ? https://raw.githubusercontent.com/errbotio/errbot/master/errbot/templates/card.md ? (it looks more like a bug in the markdown of a card under IRC)

harlowja commented 8 years ago

Ya, that could be it.

harlowja commented 8 years ago

How does one turn off that template from being used for IRC?

gbin commented 8 years ago

This card template is more little a stop gap if a backend doesn't have a send_card function (like slack, hipchat etc have). Maybe the correct way to fix this is to implement it for IRC ?