search

errbotio / errbot

Errbot is a chatbot, a daemon that connects to your favorite chat service and bring your tools and some fun into the conversation.
http://errbot.io
GNU General Public License v3.0
3.13k stars 616 forks source link

Support username with embedded @ #92

Closed silfreed closed 11 years ago

silfreed commented 11 years ago

I'm trying to connect to a server where our usernames are our email address and I'm jot sure how to make this work w/ err/xmpppy.

For example; if our email address is "user@example.com", I'm guessing I would need to enter "user@example.com@example.com" to connect to the "example.com" Jabber server with the "user@example.com" user. Unfortunately what happens is err tries to connect to the "example.com@example.com" server -- only stripping out value before the first @ sign instead of taking the server from anything after the last @ sign.

zoni commented 11 years ago

Hi silfreed, thanks for bringing this to our attention.

Just letting you know I'm going to try and have a look at this as soon as I can, but unfortunately I may not get a chance until next weekend, as I'm rather busy because of work at the moment.

Hopefully you can hold out that long... :)

silfreed commented 11 years ago

Not a problem; I'll keep poking around as I have time as well :)

gbin commented 11 years ago

I had some spare time so here is my attempt to correct that : 0e4c50c204ca89f1e2eeaec4876580c0010dcd45 Silfreed can you check if it fixes your problem ? Thx !

silfreed commented 11 years ago

From what I can tell it seems like the splitting is happening correctly, but it's still not authenticating correctly. I've been playing w/ the sasl auth in xmppy w/o luck; I can try to capture some logs if you're interested in helping, but I'm not sure what is "supposed" to be happening here :P

gbin commented 11 years ago

I have no clue on this one. Can you post the logs please ?

zoni commented 11 years ago

I'm closing this issue as it has been idle for 5 months and the originally reported issue has since been fixed.

@silfreed if you are still having issues with authentication with the current SleekXMPP-based backend, please open a new issue for this along with any relevant info (debug logs, server configuration, etc). Thanks!