search

errbuddy / babel-asset-pipeline

babel.js transformation for asset-pipeline
10 stars 6 forks source link

Don't export dependency on logging implementation #12

Closed tcrossland closed 8 years ago

tcrossland commented 8 years ago

Exporting the logging implementation (logback-classic) can cause multiple SLF4J bindings to appear in the classpath of upstream applications. Only the SLF4J API dependency is needed for compilation.

peh commented 8 years ago

Will check and merge Tonight.

peh commented 8 years ago

@tcrossland could you do me a favour and check the latest master branch (1.4.5-SNAPSHOT but it is not published so you would have to gradle localInstall it.

i removed any logging implementation and updated a lot of dependencies. tests are green but i want to make sure it's still working for you.

tcrossland commented 8 years ago

@peh Hi Philipp, 1.4.5-SNAPSHOT is working fine for me. I do have a failing test, but it's not related to the updated dependencies or the logging change:

asset.pipeline.babel.BabelProcessorSpec > Test that module IDs are generated correctly a.b/c => a.b/c FAILED

This fails when building on Windows due to the different file.separator system property.

peh commented 8 years ago

cool. thank you!