search

errbuddy / babel-asset-pipeline

babel.js transformation for asset-pipeline
10 stars 6 forks source link

Switching to Nashorn #15

Closed gferon closed 8 years ago

gferon commented 8 years ago

I was wondering why you used Rhino when Nashorn is available in JDK >= 8, and has (AFAIK) much better performance. If you see no downside to this, I think I'll try to make the change and submit a PR.

kevana commented 8 years ago

Grails 3 supports Java 1.7+, if we'd like to maintain the same level of support for the plugin then we can't drop Rhino yet. But I don't know what real-world usage stats are. My company is on Java 8 for all of our Grails apps.

peh commented 8 years ago

grails-2 java 8 support is super bumpy that's why i have not updated yet. if you want you could checkout the babel-npm branch and just implement a new Babelifier for Rhino. i am totally open to that!

gferon commented 8 years ago

This is true, springloaded breaks in horrible ways with Java 8.