Fix #6 [ImportError No Module named daemon.daemon]

errbufferoverfl / usb-canary

A Linux or OSX tool that uses psutil to monitor devices while your computer is locked. In the case it detects someone plugging in or unplugging devices it can be configured to send you an SMS or alert you via Slack or Pushover.

GNU General Public License v3.0

574 stars 66 forks source link

Fix #6 [ImportError No Module named daemon.daemon] #12

Closed amirarsalan closed 7 years ago

amirarsalan commented 7 years ago

[ ] New Feature
[x] Bug Fix

Description

add a line to requirements file that set a python daemon github url for install as requirement!

Related Issue

issue #6

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

errbufferoverfl commented 7 years ago

Hi thanks for the pull request. However, the daemon.daemon package is fulfilled by the sander-daemon package in OSX, Ubuntu and Debian, this package is included in the requirements file. This issue was fixed in version 1 see commit e23d72a and is resolved in version 2, see commit 446c09d.

The original issue was created by removing an old in built daemon and using sander-daemon and not including the import statement in the usb-canary.py (for version 1) file.

Because this issue has been resolved and closed for nearly six months, I will not be pulling the PR.