erri120 / rpgmpacker

Simple CLI program for packaging RPG Maker games to use in an automated build/deploy pipeline.
MIT License
28 stars 3 forks source link

"Change Actor Images" command doesn't mark a resource as being used #49

Closed auragamedev closed 2 years ago

auragamedev commented 2 years ago

Description Exporting while excluding unused resources also excludes resources which are only used by the "Change Actor Images" command. If I export the game with RPGM, these resources are included in the exported game.

For reproduction, you can also check here: https://gitgud.io/aura-dev/star_knightess_aura/-/jobs/176605

The character image aura_rl_brown.png should be in the exported game, but it is not copied. When exporting with RPGMaker, the file is copied correctly also when exclude unused resources is selected.

Environment Details

Logs https://gist.github.com/auragamedev/77b9724f21971b6717b3d0457b9c7c55

erri120 commented 2 years ago

https://github.com/erri120/rpgmpacker/blob/1d160b82f1b233e842b41a9055d779c51eb78b2f/src/parsedData.ts#L201-L202 https://github.com/erri120/rpgmpacker/blob/1d160b82f1b233e842b41a9055d779c51eb78b2f/src/parsedData.ts#L247-L254

hmm, I did add this event

erri120 commented 2 years ago

The event gets parsed correctly and auro_rl_brown is added to the used character names list image

erri120 commented 2 years ago

image

the file operation was also successfully created and the file was copied:

image

erri120 commented 2 years ago

The logs say the file was not copied, I guess the only difference is I'm on Windows and the CI runs on Linux. Guess I'll test with WSL

auragamedev commented 2 years ago

Just to make sure: You are on the commit from the build job used? fbf0462082f44c3698da19e7b178c4326ba3ce00 In the HEAD of the develop branch I used a workaround (added a dummy character)

erri120 commented 2 years ago

nvm was just dumb, will be fixed in 2.0.5