search

error10 / bitcoin-dist

RPM distribution of bitcoin
3 stars 0 forks source link

Bitcoin Classic is outdated #25

Closed infertux closed 6 years ago

infertux commented 7 years ago

The RPM repo doesn't package the latest version available at https://bitcoinclassic.com/downloads/index.html

PS: Any plans to package Bitcoin Unlimited as well?

PPS: Thank you for your great work :)

error10 commented 7 years ago

Bitcoin Classic 1.2.0 is not packaged because of several test failures in its test suite. I don't ship builds with failing tests, because this is people's money. At this time I cannot recommend using Bitcoin Classic.

I hadn't heard of Bitcoin Unlimited.

infertux commented 7 years ago

Bitcoin Classic 1.2.0 is not packaged because of several test failures in its test suite. I don't ship builds with failing tests, because this is people's money. At this time I cannot recommend using Bitcoin Classic.

Oh that's interesting. I wasn't aware about that and would certainly agree that packaging software with a failing test suite is bad practice. However, I wasn't able to find any kind of automated builds online like Travis CI.

So I tried to run ./autogen.sh && ./configure --with-gui=no --disable-wallet --without-miniupnpc --disable-zmq && make check on the 1.2 branch and it exited with zero/success. Could you point to the test failures you're referring to please?

2017-01-18-225310_415x215_scrot

I hadn't heard of Bitcoin Unlimited.

From my limited understanding - any bystander here is very welcome to correct me - Bitcoin Unlimited has essentially become the same as Bitcoin Classic nowadays. The only main difference is that Unlimited is trying to keep their codebase close to Core by backporting new Core features whereas Classic codebase is going its own way and adding exclusive features such as "FlexTrans". You can also check this link for more details.

error10 commented 7 years ago

The full test suite can be run with:

qa/pull-tester/rpc-tests.py -extended
zander commented 7 years ago

Bitcoin Classic runs its unit tests before deployment successfully on Ubuntu; https://launchpad.net/~bitcoinclassic/+archive/ubuntu/bitcoinclassic log; https://launchpad.net/~bitcoinclassic/+archive/ubuntu/bitcoinclassic/+build/11820464/+files/buildlog_ubuntu-yakkety-amd64.bitcoinclassic_1.2.0-yakkety_BUILDING.txt.gz

Arch; https://aur.archlinux.org/packages/bitcoin-classic/ no logs, but available in your nearest VM.

The '-extended' tests are not typically run as they are not meant to be stable, are you running those?

zander commented 7 years ago

I forgot to ask, please show which unit tests are failing for you.

The teamcity continues integration system runs all tests on all platforms (including several flavours of Linux) on a very regular basis. I don't use RPM based distro's, so maybe something is different there.

I would like to hear what the test failure is that you hit. And please consider reporting them upstream next time you hit them.

error10 commented 7 years ago

I've been running the -extended tests, the same as for building Bitcoin Core (where they virtually always pass). I'll build without running them this round, and give them another go in a week or two when I have some more time.

infertux commented 6 years ago

https://bitcoinclassic.com/news/closing.html