search

erseco / alpine-moodle

Moodle docker image based on Alpine Linux
https://hub.docker.com/r/erseco/alpine-moodle
MIT License
42 stars 33 forks source link

Implementing redis and ldap support #23

Closed kuzakov closed 1 year ago

kuzakov commented 1 year ago

Hi Ernesto! I was really happy when I found your repository for making docker image for Moodle. But I was little disappointed when I knew that your images aren't supporting Redis and LDAP.

And I decided that I can improve your code for supporting this. Also, I added opportunity to adding trusted certificates when you are using self-signed certificates on your AD by encoding your certificate or chain of certificates to base64 and provide this as a simple string variable when deploying.

This approach I've successfully tested in Kubernetes in my company.

Best regards, Denis

erseco commented 1 year ago

Dear Denis,

Thank you for your message and for your contribution. We appreciate your efforts in improving the code and adding support for Redis and LDAP, as well as providing the option to add trusted certificates when using self-signed certificates on your PR.

We have reviewed your pull request and are pleased to accept it. Your contributions will certainly enhance the functionality of the images and will be valuable to other users who may encounter similar issues.

Once again, thank you for your time and effort in making these improvements to the repository. We look forward to working with you in the future.

Best regards.

erseco commented 11 months ago

In the last release I improved the redis configuration adding a cachestore, feel free to test it :)

Thanks!