search

ersel / spotify-cli-mac

🎶 A nodejs app to control Spotify without leaving your terminal. 🎶
MIT License
183 stars 28 forks source link

Add Git Commit Hook to check Lint #14

Closed ersel closed 7 years ago

ersel commented 7 years ago

We can set a pre-commit hook to run eslint for any lint issues using husky. This should be installed as a dev-dependency only.

https://github.com/typicode/husky

aterranova-bv commented 7 years ago

I can pick this one up, Happy Hacktoberfest! 👻 🎃 👻 🎃 👻 🎃

ersel commented 7 years ago

Great, feel free to submit a PR @aterranova-bv

jakehasler commented 7 years ago

@aterranova-bv Sorry man, I started working on this before I saw that you had claimed it.

@ersel Here is the PR: https://github.com/ersel/spotify-cli-mac/pull/15

ersel commented 7 years ago

No worries @jakehasler , thanks for your contribution. I'll merge outstanding PRs this weekend.

ersel commented 7 years ago

Feel free to look into testing or refactoring related issues if you like to @aterranova-bv , thanks for your interest.

aterranova-bv commented 7 years ago

Just seeing this, I opened one as well #17 lol 😝 .

No worries mate, this is a cool project!

ersel commented 7 years ago

Haha happy hacking my friend, thanks for your contribution! 🤓