ersilia-os / eos-template

Template repository to add new models to the Ersilia Model Hub
GNU General Public License v3.0
1 stars 2 forks source link

[Spike] Model Test on PR not triggered when editing the PR #17

Closed GemmaTuron closed 1 year ago

GemmaTuron commented 1 year ago

We have set the Model test on PR Git Action to be triggered when a PR is opened to merge a fork from a contributor back to the model repository We have noticed that it is triggered when the PR is open, but if the test fails, the contributor edits the PR and commits again the PR is not triggered See this example: The tests failed on commit [b9fc637] but upon modifying and commiting again, only 2 tests were triggered https://github.com/ersilia-os/eos74bo/pull/2

megamanics commented 1 year ago

@GemmaTuron

Files changed TAB in that PR shows that the workflow files were removed perhaps by mistake. https://github.com/ersilia-os/eos74bo/pull/2/files#diff-37ef7c121984d6a78a9596ee981802f7a59b6aed8265ebdd22c1a5938764b53f

https://github.com/ersilia-os/eos74bo/pull/2/commits/566394b9c9369e81f385916b91d9a47c528cfdc4#diff-37ef7c121984d6a78a9596ee981802f7a59b6aed8265ebdd22c1a5938764b53f

image

GemmaTuron commented 1 year ago

Hi @megamanics

I think these were just changes I was testing. The issue of the tests not being triggered is persisting; here you can see another example, where the first PR activates the 3 tests but then the addition of a modification does not trigger it, hence it seems is passing the tests but it's actually not: https://github.com/ersilia-os/eos4avb/pull/1#issuecomment-1419577498

GemmaTuron commented 1 year ago

@megamanics

Tested again with removing the [opened, reopened, edited] options and it works just fine. So let's close this issue, thanks for the help!