search

ersilia-os / eos-template

Template repository to add new models to the Ersilia Model Hub
GNU General Public License v3.0
1 stars 2 forks source link

[Spike] Model testing fails because of Git LFS pointers #20

Closed GemmaTuron closed 1 year ago

GemmaTuron commented 1 year ago

Hi @GrantBirki and @megamanics

We have noticed a bug in our Model Submission workflow we do not know how to troubleshoot. The workflow is as follows:

  1. Contributor opens Model Issue Request
  2. Upon approval, a repository is created based on eos-template
  3. A mock Git-LFS object is added so that contributors can add git-lfs objects in their forks if needed
  4. Contributors fork the repository, work on incorporating the model and make a PR
  5. The PR triggers the model test on PR Action
  6. If the PR is merged, the model test on Push Action is triggered as well

Both at model test on PR and model test on push the "Predict Output" (so, testing the model is working) fails, because the model checkpoints (stored with Git - LFS) are not properly fetched

It must be something with how Git Action tries to fetch the Git LFS pointers, because the models work fine when testing in local through the Ersilia CLI

GemmaTuron commented 1 year ago

An example of this: https://github.com/ersilia-os/eos4avb/actions/

GemmaTuron commented 1 year ago

This is solved when the following is added: with: lfs: true