search

ersilia-os / eos-template

Template repository to add new models to the Ersilia Model Hub
GNU General Public License v3.0
1 stars 2 forks source link

Add retries to model test workflows #44

Closed DhanshreeA closed 4 months ago

DhanshreeA commented 7 months ago

Can possibly use something like this action from the marketplace: https://github.com/marketplace/actions/retry-step

DhanshreeA commented 4 months ago

@dzumii do you want to take a look at this?

dzumii commented 4 months ago

Yes, I will @DhanshreeA

dzumii commented 4 months ago

So i am thinking of adding the retries to the both the model-test-on-push and model-test-on-PR workflows and specifically the install dependencies,install ersilia,Update metadata to AirTable, Update README file and Predict output actions with 3 maximum attempts and 10 minutes wait time for each attempt. What do you think? @DhanshreeA

DhanshreeA commented 4 months ago

Hey @dzumii great first start to this issue - I think, purely from experience, that only the Predict output and Update metadata to Airtable steps would indeed merit from retries across both the workflows that you mentioned, since they could fail due to flaky network issues/API rate limits and such.

dzumii commented 4 months ago

Ok! Thanks for the clarification @DhanshreeA