ersilia-os / eos-template

Template repository to add new models to the Ersilia Model Hub
GNU General Public License v3.0
1 stars 2 forks source link

📑 Feature Request: include a `.dockerignore` file in the `eos-template` #71

Open miquelduranfrigola opened 1 month ago

miquelduranfrigola commented 1 month ago

Include a .dockerignore file in the eos-template

For some models such as eos3ujl it would be convenient to have files that are not strictly necessary to serve and run the model. For example, in that model, we had to fit an extra imputer and we would like to keep the data used for that fitting, although this data is no longer necessary once the imputer is stored as a .joblib file.

It would therefore be very convenient to have the following:

  1. In the GitHub repository and S3 bucket, everything can be stored.
  2. In the Docker container, only the necessary files are stored.

To allow for this to happen in CI/CD, I suggest the following approach:

  1. We include a .dockerignore file that functions exactly like a .gitignore file. That is, paths relative to the root of the directory can be specified there (with wildcard character * allowed).
  2. Then, in CI/CD, before building the Docker image, we can remove all files specified in the .dockerignore file.

@DhanshreeA please let me know if this sounds like a good approach.

Subtasks would be:

DhanshreeA commented 1 month ago

Hey @miquelduranfrigola sounds like a good approach! Although this issue should have technically been created as a Task instead of Feature Request (those are for users and contributors)

miquelduranfrigola commented 1 month ago

Hi @DhanshreeA I have added a .dockerignore file in this repository: https://github.com/ersilia-os/eos3mk2

DhanshreeA commented 2 weeks ago

I can take this up this week.

GemmaTuron commented 6 days ago

Hi @DhanshreeA !

This task is On Hold. Please update the status/priority if it is something being actively worked on