ersilia-os / eos3804

GNU General Public License v3.0
0 stars 0 forks source link

BioModel Discussion Issue for eos3804 #5

Open Zainab-ik opened 2 months ago

Zainab-ik commented 2 months ago

Summary !!!

Zainab-ik commented 2 months ago

@GemmaTuron Kindly review

GemmaTuron commented 2 months ago

Hi @Zainab-ik

This paper is the continuation of Chemprop (Stokes et al, 2020) which was developed in E.coli data. The model is focused only on A.baumannii. I would look at the metadata of eos4e40 - most of it should be the same, only the organism is different.

This arises a question - are we collecting the data about whether the model is validated experimentally or not? I think that might be a valuable field to collect

Zainab-ik commented 2 months ago

Hi @Zainab-ik

This paper is the continuation of Chemprop (Stokes et al, 2020) which was developed in E.coli data. The model is focused only on A.baumannii. I would look at the metadata of eos4e40 - most of it should be the same, only the organism is different.

Yes, they are mostly the same.

This arises a question - are we collecting the data about whether the model is validated experimentally or not? I think that might be a valuable field to collect

After discussing with Sheriff, the metadata Experimental Validation with this ontology or this and the hasProperty tag has been added to the annotation and it's ready for review.

GemmaTuron commented 2 months ago

@Zainab-ik For this model and others, let's clarify

The fact that the authors use a library for validating the results in this case, Drug Repurposing Hub, this is not a Data Source, and it should not be listed as such. Let's revise if this has happened in other models as well Also, how do we highlight that a model has external validation in the lab? And why QSAR is not in this model but it appears in others? we should be consistent with it

Zainab-ik commented 2 months ago

@Zainab-ik For this model and others, let's clarify

The fact that the authors use a library for validating the results in this case, Drug Repurposing Hub, this is not a Data Source, and it should not be listed as such. Let's revise if this has happened in other models as well Also, how do we highlight that a model has external validation in the lab? And why QSAR is not in this model but it appears in others? we should be consistent with it

To clarify, validation dataset doesn't qualify as a metadata for the model. Well note. Regarding the external validation; they are usually experimental, right? And the idea/solution is to add a Experimental validation/Method metadata to the annotation. Well sorted with the QSAR.

GemmaTuron commented 2 months ago

The compound identification field we discussed is not relevant The experimental validation could indicate whether it is in vitro or in vivo

Zainab-ik commented 2 months ago

The compound identification field we discussed is not relevant The experimental validation could indicate whether it is in vitro or in vivo

the experimental validation is both so I added both in vivo and in vitro.

GemmaTuron commented 2 months ago

if all the changes are made let's add the model to biomodels!