ersilia-os / eos6tg8

GNU General Public License v3.0
0 stars 0 forks source link

New model ready for testing! #1

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

This model is ready for testing. If you are assigned to this issue, please try it out using the CLI, Google Colab and DockerHub and let us know if it works!

pittmanriley commented 1 year ago

Hi @GemmaTuron, I was able to fetch and get the model to run well on Docker and Colab, but I wasn't able to fetch it on CLI in the terminal or Codespaces. It keeps saying that the 'torch' module is not found, but I'm not sure how the model was able to fetch on Colab or Docker if this isn't working on CLI. Here's the error log: eos6tg8_error.log

And here are the outputs:

Colab: eos6tg8_colab.csv

Docker: eos6tg8_docker.csv

GemmaTuron commented 1 year ago

Hi @pittmanriley,

If you have a look at the error, it seems you have issues with git lfs. I think we already run into this in another model so make sure your git lfs is working properly, it would explain why models are not working on the CLI

Hook already exists: post-commit

        #!/bin/bash

        # This is a custom git hook installed for codespaces when you'll be unable to push your changes to the source repository.
        # Instead, we'll fork the repo on your behalf, ensure you have appropriate permissions, and transfer the codespace to that fork.

        trap "mv $0 $0.codespaces-disabled" EXIT

        echo "You don't have write access to the $GITHUB_REPOSITORY repository, so you cannot push changes to it."
        echo "To obtain write access we will point this codespace at your fork of $GITHUB_REPOSITORY, creating that fork if it doesn't exist."
        echo

        if [ -t 1 ]; then
        read -p "Would you like to proceed? " -n 1 -r < /dev/tty
        echo
        if [[ ! $REPLY =~ ^[Yy]$ ]]
        then
        exit 0
        fi
        fi

        URL="https://api.github.com/vscs_internal/user/$GITHUB_USER/codespaces/$CODESPACE_NAME/fork_repo"

        current_branch=$(git rev-parse --abbrev-ref HEAD)

        response=$(curl -s -w "%{http_code}" -X POST -H "Authorization: token $GITHUB_TOKEN" -d "{\"branch\":\"$current_branch\"}" $URL)

        # Grab the last line which is the status code
        http_cod

To resolve this, either:
  1: run `git lfs update --manual` for instructions on how to merge hooks.
  2: run `git lfs update --force` to overwrite your hook.
GemmaTuron commented 1 year ago

@simrantan

While Riley works on this issue with git lfs, please also try out this model to see if it actually works and is just an issue on Riley's end!

pittmanriley commented 1 year ago

@GemmaTuron I tried fetching without any flags on CLI, and got it to work. Here's the output: eos6tg8_cli.csv

Is it good enough if I got it to work using ersilia -v fetch eos6tg8? Or do we need it to work using --repo_path or --from_github?

simrantan commented 1 year ago

I tested the model and it fetches and outputs fine for me on all platforms! @GemmaTuron @pittmanriley Colab Output

Docker eos6tg8Docker.txt

CLI output6tg8.csv

GemmaTuron commented 1 year ago

@GemmaTuron I tried fetching without any flags on CLI, and got it to work. Here's the output: eos6tg8_cli.csv

Is it good enough if I got it to work using ersilia -v fetch eos6tg8? Or do we need it to work using --repo_path or --from_github?

@pittmanriley

When you fetch without any flag, it will fetch the model from Docker (you'll see it in your dockerhub being activated). Testing --from_github is a good test to make sure the conda env works, but it might fail in a MacBook, if the model is not set up for it. Testing using the repo_path flag is the same basically as --from_github, unless you are doing changes to the local clone of the repo