search

ersilia-os / eos7pw8

GNU General Public License v3.0
2 stars 1 forks source link

Converted the syba package into a .zip file and fetched it using wget #15

Closed samuelmaina closed 1 year ago

samuelmaina commented 1 year ago

-Able to fetch from colab. colab_eos7pw8_fetch (1).log

samuelmaina commented 1 year ago

@GemmaTuron , I have made the changes. Can you have look a look?

GemmaTuron commented 1 year ago

Hello @samuelmaina

I see you are both downloading the package each time with the wget command and also adding it in the repository:

RUN wget https://github.com/samuelmaina/eos7pw8/raw/main/syba-master.zip
RUN unzip syba-master.zip && cd syba-master
RUN python setup.py install
RUN rm -rf syba-master.zip syba-master

If you add it in the repository, please delete the wget command. Also, the zip file is the model checkpoints, so place it in the correct place. There is two copies of a legacy file (placea...) that must be deleted

GemmaTuron commented 1 year ago

That looks good, can you also delete the files place_a_docker... which I see duplicated twice in your fork, and then I'll merge the PR?

samuelmaina commented 1 year ago

Okay. I will remove it.

samuelmaina commented 1 year ago

Hi @GemmaTuron , test run successfully.