search

ersilia-os / eos7pw8

GNU General Public License v3.0
2 stars 1 forks source link

Made Copy in Dockerfile receive two args instead of 1 #19

Closed samuelmaina closed 1 year ago

samuelmaina commented 1 year ago

HI @GemmaTuron , The file place_a_dockerfile_in_current_eos_repo.py is not being deleted by the workflows for the this repo, I think there should be a rm place_a_dockerfile_in_current_eos_repo.py: at the end of this generate-dockerfile step in the upload-model-to-dockerhub.yml workflows


        id: generate-dockerfile
        env:
          REPO_NAME: ${{ github.event.repository.name }}
        run: |
          wget https://raw.githubusercontent.com/ersilia-os/ersilia/master/.github/scripts/place_a_dockerfile_in_current_eos_repo.py
          python -m pip install requests
          python place_a_dockerfile_in_current_eos_repo.py $REPO_NAME
GemmaTuron commented 1 year ago

Hi @samuelmaina

It's just that theworkflow is slightly outdated, see this issue: https://github.com/ersilia-os/ersilia/issues/719 Please if you modify it make sure to place it where the current rm command is in the eos-template workflow https://github.com/ersilia-os/eos-template/blob/main/.github/workflows/upload-model-to-dockerhub.yml

samuelmaina commented 1 year ago

I have just updated the workflow to their latest version, I think this will solve the issue

samuelmaina commented 1 year ago

@GemmaTuron , The tests have passed.