search

ersilia-os / ersilia-pack

Module to pack Ersilia models with FastAPI
GNU General Public License v3.0
2 stars 6 forks source link

Edge cases in pip depedency handling #21

Open DhanshreeA opened 2 months ago

DhanshreeA commented 2 months ago

The dependency parser should be extended to handle dependencies of the form:

pip install git+https://github.com/bp-kelley/descriptastorus.git@d552f934757378a61dd1799cdb589a864032cd1b

Currently it expects four parameters in a pip install command, ie, pip, install, dependency, and version. This approach would clearly fail for when wheel files/paths/urls are provided.

DhanshreeA commented 2 months ago

Adding to this:

How we end up rewriting the values from a yaml to a pip command would also not take into account additional parameters for example, something like,

pip install torchvision==0.17.1  --index-url https://download.pytorch.org/whl/cpu
jubril-adeyi commented 1 month ago

Hi @DhanshreeA , I'd like to take on this issue

DhanshreeA commented 1 month ago

Sure, @jubril-adeyi! Assigning you this one as your other issue is close to completion.

dzumii commented 1 month ago

@jubril-adeyi How is this going? Any progress?

jubril-adeyi commented 1 month ago

@dzumii Thanks for checking in, I’ve been focused on rounding up the previous issue, but I’ll be diving into this one now. I’ll provide a more detailed update shortly as I make progress.

jubril-adeyi commented 1 month ago

@DhanshreeA I've been taking some time to digest the parser.py file and understand the different components and their roles. The file contains various classes and methods, each designed to handle parsing and conversion flow. I'm carefully going through each section to get a clear picture of how the logic flows and have a comprehensive understanding before proceeding with any changes.

GemmaTuron commented 3 weeks ago

Hi @DhanshreeA

There is a PR open on this. Could you revise and close/merge when you can? Thanks