📑 Feature Request: Configure model docker builds to be rebuilt with older Dockerfiles

ersilia-os / ersilia

The Ersilia Model Hub, a repository of AI/ML models for infectious and neglected disease research.

https://ersilia.io

GNU General Public License v3.0

224 stars 148 forks source link

📑 Feature Request: Configure model docker builds to be rebuilt with older Dockerfiles #1104

Closed DhanshreeA closed 6 months ago

DhanshreeA commented 7 months ago

Is your feature request related to a problem? Please describe.

No response

Describe the solution you'd like.

No response

Describe alternatives you've considered

No response

Additional context.

No response

DhanshreeA commented 7 months ago

[x] Restore Dockerfiles for single stage builds in a folder called model-deploy-single-stage
[x] Configure this script to accept a flag input and based on this flag, decide whether to use the single stage or multi stage builds
[x] Update workflow in eos-template to try multi stage build and if it fails, fallback to single stage builds.
[x] Update base image build workflow to build and upload the v1 ersilia base image.

DhanshreeA commented 7 months ago

Note on Nomenclature

v1: Old build logic which utilized a single base image and a model image as part of a single stage build
v2: New build logic which utilizes multi stage build

DhanshreeA commented 7 months ago

Partly addressed here: https://github.com/ersilia-os/ersilia/pull/1112

DhanshreeA commented 6 months ago

The remainder of the tasks re updating eos-template repo workflows addressed here: https://github.com/ersilia-os/eos-template/pull/46

DhanshreeA commented 6 months ago

We have unfortunately had to introduce two ersilia base images and that is NOT ideal. There is some background work required to support v1 and v2 with the same base image.