ersilia-os / ersilia

The Ersilia Model Hub, a repository of AI/ML models for infectious and neglected disease research.
https://ersilia.io
GNU General Public License v3.0
224 stars 148 forks source link

🐈 Task: Bump requests and docker-py versions in ersilia #1146

Closed DhanshreeA closed 10 hours ago

DhanshreeA commented 5 months ago

Summary

From a dependabot alert:

When making requests through a Requests Session, if the first request is made with verify=False to disable cert verification, all subsequent requests to the same origin will continue to ignore cert verification regardless of changes to the value of verify. This behavior will continue for the lifecycle of the connection in the connection pool. Remediation

Any of these options can be used to remediate the current issue, we highly recommend upgrading as the preferred mitigation.

Upgrade to requests>=2.32.0.
For requests<2.32.0, avoid setting verify=False for the first request to a host while using a Requests Session.
For requests<2.32.0, call close() on Session objects to clear existing connections if verify=False is used.

Related Links

https://github.com/psf/requests/pull/6655

Objective(s)

Documentation

https://github.com/psf/requests/issues/6707 https://github.com/psf/requests/pull/6710

GemmaTuron commented 2 months ago

Hi @DhanshreeA,

There is an open PR regarding this issue. Is it safe to merge it?

DhanshreeA commented 1 month ago

This is presently unsafe to merge, I was facing errors in ersilia tests that I was not able to resolve at the time. I will give another crack at this and close it.

GemmaTuron commented 1 week ago

Hi @DhanshreeA

What is the plan for that? has this been merged?