ersilia-os / ersilia

The Ersilia Model Hub, a repository of AI/ML models for infectious and neglected disease research.
https://ersilia.io
GNU General Public License v3.0
196 stars 128 forks source link

🐈 Task: Reflect correct values in information.json #1196

Closed DhanshreeA closed 1 day ago

DhanshreeA commented 1 month ago

Summary

Presently, when a model is fetched from DockerHub, the information.json file, which we rely upon for retrieving general characteristics about a fetched model, is copied from the container storage to the host storage - however this is incorrect since it is only a representation of the model environment inside the container and not the one on the host machine.

Eg: If I fetch eos3b5e from DockerHub, as per the information.json made available on my machine, the model's size is <1MB, and its service class is conda. However, the model size is ~750 MB (the model image size), and the model's service class is pulled_docker.

The information.json file is currently being used in the following ways:

  1. In ErsiliaModel.info()
  2. In LocalCard._load_data()
  3. ModelInformer.init()
  4. ModelHostedFetcher.get_information() and ModelHostedFetcher.get_metadata()
  5. PulledDockerImageService._get_memory()
  6. StandardCsvRunApi.get_input_type() and StandardCsvRunApi.is_output_type.standardizable()
  7. Ersilia test

Objective(s)

TODO

Documentation

No response

DhanshreeA commented 1 month ago

@dzumii and @Malikbadmus do you wanna look into this?

dzumii commented 1 month ago

Yes

DhanshreeA commented 1 month ago

@Malikbadmus or @dzumii could you please update the issue Objectives with what we've discussed about regarding how to proceed with this? :) Thank you!

Malikbadmus commented 1 month ago

@Malikbadmus or @dzumii could you please update the issue Objectives with what we've discussed about regarding how to proceed with this? :) Thank you!

@DhanshreeA , I an unable to edit the issue to make the modifications regarding this.

dzumii commented 1 month ago

I am also unable to edit @Malikbadmus i think we can just add it as a comment instead of editing the first comment

DhanshreeA commented 1 day ago

This has been resolved.