Open DhanshreeA opened 2 days ago
Hello @DhanshreeA , I would like to work on this as well as think about the edge cases. Would the uninstall be mostly difficult because of the different operating systems or are there other factors as well?
Hi @DhanshreeA
Do you think there is a way to wrap all of this into a pip uninstall ersilia
and/or conda uninstall ersilia
instead of ersilia uninstall
? I mean, uninstalling everything (i.e. deleting docker images, removing the eos
folder, etc.) using the pip
and conda
commands (depending on how ersilia
was initially installed) would make a lot of sense, but I am not sure if it is even possible to do.
Hi @DhanshreeA Do you think there is a way to wrap all of this into a
pip uninstall ersilia
and/orconda uninstall ersilia
instead ofersilia uninstall
? I mean, uninstalling everything (i.e. deleting docker images, removing theeos
folder, etc.) using thepip
andconda
commands (depending on howersilia
was initially installed) would make a lot of sense, but I am not sure if it is even possible to do.
I will have to look into this - especially if we have to add anything as package data that we don't usually do during install time.
Hi @ProfessionalCaddie
Thanks for your interest! We are opening these issues for the Outreachy applicants that are starting next week, so we will assign those to Outreachy applicants only at the moment. The Ersilia maintainers team is only three of us and we cannot provide support to too many new contributors at the same time. I hope you understand! Once the Outreachy application period is complete (November), we will be back to having space to onboard new open source contributors.
Summary
Related to #1262
Ersilia clear command really uninstalls everything and therefore we want to rename it to
uninstall
to more clearly reflect that. At present it does not remove docker images for models that have been fetched from DockerHub. In addition to fixing that, we want to extend it in a way that ersilia is able to uninstall itself from the user's system.Objective(s)
clear
touninstall
in the command's definition. This would typically involve refactoring everything from the class name (Clearer
->Uninstaller
), function names, updating the help text for the command, etc.ersilia delete --all
(ref: #1265) to delete all models, including the dockerized models as well.For now, the first two objectives are straightforward to address - and we can discuss approaches and edge cases for the last objective pertaining to ersilia uninstall.
Documentation
No response