search

ersilia-os / ersilia

The Ersilia Model Hub, a repository of AI/ML models for infectious and neglected disease research.
https://ersilia.io
GNU General Public License v3.0
224 stars 148 forks source link

🐛 Bug: Catalog command showing models in progress #1388

Open GemmaTuron opened 2 days ago

GemmaTuron commented 2 days ago

Describe the bug.

When I run ersilia catalog --more to see all available models, I get things like:

    {
        "Identifier": "eos9zfb",
        "Slug": null,
        "Title": "Ersilia Model In Progress"
    },

Where is the catalog command reading from? and of course models in progress should not be read.

Describe the steps to reproduce the behavior

No response

Operating environment

Ubuntu 22.04 LTS

GemmaTuron commented 2 days ago

I am giving this a high priority because the CLI commands should work without errors or small bugs like this one.

DhanshreeA commented 1 day ago

Hi @GemmaTuron, the ersilia catalog reads from S3 or AirTable by default, ie from the hub, if the flag --local is not specified. At present there is no filter on the response received from S3/AirTable either, and since the --more flag currently only displays three fields when getting this data from the hub, viz., 'Identifier', 'Slug', and 'Title', and not the 'Status' field it does not make sense to implement a filter unless we first increase the scope of the data fetched from the hub.

Regarding this particular model that appears in the result, I noticed that this is an archived repository with no clear explanation as to how or when this was created. I will delete this repository once we conclude this discussion.

If you want to see all locally available models, you would need to use ersilia catalog --local --more. From a usability point of view, do you think you would benefit if we made reading local models a default behavior and reading from the hub optional, so you don't have to always use this flag?