ersilia-os / ersilia

The Ersilia Model Hub, a repository of AI/ML models for infectious and neglected disease research.
https://ersilia.io
GNU General Public License v3.0
203 stars 131 forks source link

📑 Feature Request: Improving Contributing MD #592

Closed GemmaTuron closed 1 year ago

GemmaTuron commented 1 year ago

Is your feature request related to a problem? Please describe.

The contribution file could be much more exhaustive, using as templates some of the suggestions by @DhanshreeA https://scikit-learn.org/stable/developers/contributing.html https://pandas.pydata.org/docs/development/index.html

Describe the solution you'd like.

Our current interns and contributors to modify the Contributing.md with the information they would have found useful to have

Please let me know here if you can help us out in this issue and I'll assign it to you :)

Describe alternatives you've considered

I can try to work on it but I think actual contributors will do a much better job of covering the things they needed to see

Additional context.

No response

DhanshreeA commented 1 year ago

Hi @GemmaTuron I would love to contribute to this. Can you point me to some internal documentation we may already have about the ersilia cli code base? I have some understanding of it from debugging issues within model incorporation but a high level overview would be much appreciated. :)

GemmaTuron commented 1 year ago

Hi @DhanshreeA and all,

As we just discussed,the best documentation is on GitBook. Here, we are looking at a contributing.md that explains the basic contribution workflow:

So actually a quite "high level" documentation

Femme-js commented 1 year ago

Hi @GemmaTuron !

Going through the above discussion, I would like to add 'Landing your pull request' and describe it in detail in contributing.md.

Should I open another issue for it, or you can assign one to me?

GemmaTuron commented 1 year ago

@Femme-js

Sounds good, go ahead and make a PR to modify the contributing.md

GemmaTuron commented 1 year ago

I'll close this comment due to inactivity, I've made minor changes to the file, including a comment from @Femme-js