search

ersilia-os / ersilia

The Ersilia Model Hub, a repository of AI/ML models for infectious and neglected disease research.
https://ersilia.io
GNU General Public License v3.0
203 stars 131 forks source link

🐛 Bug: Updating metadata to airtable #625

Closed GemmaTuron closed 1 year ago

GemmaTuron commented 1 year ago

Describe the bug.

Once a contributor makes a PR to include a new model in the Hub, and the PR passes all the checks (including the model_test_on_pr) it fails to merge it because of a problem in updating metadata to airtable. The AirTable API key has not changed (when we create a new repo we are able to write automatically to airtable, I just checked) so it is not this. This happens, that I know of, since a couple of days ago. I have tried to debug with the following, using the repo eos9yy1 as example. I have modified the model_test.yml file to install a previous version of ersilia (tried with 5March and 15 Feb, as appears in the commits, but the error persists (though it might be because the Git Action is running the most recent code at some point and I might have missed the change)

@miquelduranfrigola can we revise if your changes for the issue #610 have anything to do with this?

Describe the steps to reproduce the behavior

  1. Go to the model eos9yy1
  2. Make a small change in a dummy file to trigger the action workflow
  3. Revise the outcome of the action

Expected behavior.

Metadata updated in the readme file

Screenshots.

No response

Operating environment

Ubuntu 20.04 LTS

Additional context

No response

carcablop commented 1 year ago

This also happened when merging these changes now: https://github.com/ersilia-os/eos22io/actions/runs/4375570167/jobs/7656453067

GemmaTuron commented 1 year ago

The issue was due to some empty lines in airtable, which we have now removed. We have also added a warning in the git action in case this happens again. I've re run the workflow @carcablop without issues now ;)