[🐅 Epic]: Simultaneous serving of models

miquelduranfrigola commented 1 year ago

Request

At the moment, the session.json file only works with one model at a time. Whenever we are serving Ersilia models via DockerHub, then in principle multiple sessions could be allowed.

Expected behaviour

[x] If at least one of the served models is not served from docker, then send a warning and close all models served.
[x] If all models served are pulled_docker, then multiple sessions are possible.
[x] Each terminal should serve one and only one model. This is important to avoid unwanted mistakes from the user. Alternatively, we can allow for multiple runs in the same terminal if and only if the model_id is specified.

Suggested solution

session.json could be a list, each element corresponding to one session.

DhanshreeA commented 5 months ago

Related to #1109

GemmaTuron commented 2 months ago

@DhanshreeA

What is the status of this?

GemmaTuron commented 1 month ago

Hi @DhanshreeA Is this on Queue or In Progress? What is the plan?

DhanshreeA commented 1 month ago

@GemmaTuron this has been implemented IS actually working exactly as expected now, re all the points within expected behavior section. I think we can close this. This is also related to #1197 (which I thought was a bug but it is not, as per the behavior defined here.)

ersilia-os / ersilia