ersilia-os / ersilia

The Ersilia Model Hub, a repository of AI/ML models for infectious and neglected disease research.
https://ersilia.io
GNU General Public License v3.0
198 stars 128 forks source link

🐛 Bug: update metadata for new models #893

Closed GemmaTuron closed 9 months ago

GemmaTuron commented 9 months ago

Describe the bug.

The "approve dispatch" command to create new repos was failing when updating metadata - see https://github.com/ersilia-os/ersilia/actions/runs/6979079982/job/18992147729

The parsing of the JSON field changed (not sure when or in which script) but it now parses the tag as a list already

{'model_name': 'Antituberculosis activity prediction', 'model_description': "Prediction of the activity of small molecules against Mycobacterium tuberculosis. This model has been developed by Ersilia thanks to the data provided by the Seattle Children's (Dr. Tanya Parish research group). In vitro activity against M. tuberculosis was measured i na single point inhibition assay (10000 molecules) and selected compounds (259) were assayed in MIC50 and MIC90 assays. Cut-offs have been determined according to the researcher's guidance.", 'slug': 'antitb-seattle', 'tag': ['M.tuberculosis', 'Antimicrobial activity', 'MIC90', 'Tuberculosis'], 'publication': 'https://ersilia.io/', 'source_code': 'https://github.com/ersilia-os/lazy-qsar', 'license': 'GPL-3.0'} File "/home/runner/work/ersilia/ersilia/.github/scripts/update_metadata.py", line 115, in populate_metadata tags = [tag.strip() for tag in self.json_input["tag"].split(",")]

Describe the steps to reproduce the behavior

No response

Expected behavior.

No response

Screenshots.

No response

Operating environment

Ubuntu 20.04 LTS

Additional context

No response

GemmaTuron commented 9 months ago

@miquelduranfrigola

Just for your info, I've solved this by simply passing the list directly