ersilia-os / ersilia

The Ersilia Model Hub, a repository of AI/ML models for infectious and neglected disease research.
https://ersilia.io
GNU General Public License v3.0
224 stars 148 forks source link

Ersilia to provide validation script for molecules #908

Closed seanmarcia closed 5 months ago

seanmarcia commented 11 months ago

It was mentioned that there is a script that is run to validate that data entered is correct/valid. Ersilia needs to provide that so we can implement it as an action.

miquelduranfrigola commented 11 months ago

Hi @seanmarcia

This is already done by Ersilia to a large extend when we run a model. If the file is not correct, it will crash? Do you think this is enough, or should we have a validation script previous to running?

If so, I would just do a simple validaton:

miquelduranfrigola commented 11 months ago

Alternatively, I can create some simple functionality such as ersilia test --input input.csv but I think that it would be overkill, since the action will have to install ersilia. As mentioned above, if we just write a couple of lines inside the workflow file to check extension and check that there is one and only one column, that should be sufficient for now.

DhanshreeA commented 5 months ago

@miquelduranfrigola or @GemmaTuron good to close this issue?

GemmaTuron commented 5 months ago

yes!