search

erskingardner / nostr-how

https://nostr.how
111 stars 49 forks source link

Start Posting Notes page #174

Closed boston-wine closed 4 months ago

boston-wine commented 8 months ago

A page for getting started creating notes. I think I'm doing this right...

vercel[bot] commented 8 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @erskingardner on Vercel.

@erskingardner first needs to authorize it.

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nostr-how ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 10:17am
erskingardner commented 8 months ago

@boston-wine I noticed that we actually already have a setup zapping wallet page as a guide: https://nostr.how/en/guides/setup-zapping-wallet

Do you think your new page should replace this guide or should we just keep what we have?

boston-wine commented 8 months ago

Hey @erskingardner apologies for any confusion - the only new content should be the "start posting notes" page. The zapping wallet guide I created does need some updates/edits, but I did not include those changes in this PR. Happy to submit a separate PR with those changes once I've got them done right.

And let me know if there was a cleaner way to submit this PR that wouldn't imply changes to the older page ;)

Thanks!

@boston-wine I noticed that we actually already have a setup zapping wallet page as a guide: https://nostr.how/en/guides/setup-zapping-wallet

Do you think your new page should replace this guide or should we just keep what we have?

erskingardner commented 7 months ago

you're going to need to either create a new commit deleting or moving the zapping wallet page into a _drafts folder or something. Right now, both files are still in the PR and they will both show up on the site if merged.

While you're at it, one other thing you can do is to add the start posting notes page to the sidebar nav, which lives in the Sidebar.svelte component.

erskingardner commented 4 months ago

Is this ready for a merge now?

boston-wine commented 4 months ago

Closing this PR as it's been a while and I'd rather re-sync my fork and open a new PR. Learning as I go.