search

erskingardner / nostr-how

https://nostr.how
111 stars 49 forks source link

Create start-posting-notes.md #192

Closed boston-wine closed 2 weeks ago

boston-wine commented 4 months ago

Re-do on creating the "Start Posting Notes" page. Closed the old PR, synced to your current repo.

I think this is right, now, as the only difference between my fork and your original is this page.

Let me know if I should update the sidebar like you had mentioned on the old PR. If so, I found where to add the page to the sidebar, but was not sure how I should edit the line that identifies the page. Each menu item is formatted like this:

{ href: "/guides/setup-zapping-wallet", localeString: "nav.guideSetupWallet" }, So presumably, mine should look something like this, but I'm not clear on what the text at the end should actually say, or if I need to define it elsewhere (like on the actual Start Posting Notes page).

{ href: "/guides/start-posting-notes", localeString: "nav.guide__?_?_?__" },

Anyway, if it makes no difference to you, @erskingardner, it's probably simpler for me to learn/cement the PR process by just working on this page by itself, and then making a separate, second change to update the sidebar nav, so that I get the practice with syncing, forking, editing, and opening pull requests.

Oh, and let me know if you'd advise any changes to the copy itself 🫡

vercel[bot] commented 4 months ago

@boston-wine is attempting to deploy a commit to the Jeff Gardner's projects Team on Vercel.

A member of the Team first needs to authorize it.

erskingardner commented 4 months ago

Let me know if I should update the sidebar like you had https://github.com/erskingardner/nostr-how/pull/174#issuecomment-1928950394 on the old PR. If so, I found where to add the page to the sidebar, but was not sure how I should edit the line that identifies the page. Each menu item is formatted like this:

Ok... unfortunately this is where this repo gets a bit complicated because of the translations. The localeString values are stored in the /src/lib/locales/ directory. Each file in there contains the UI strings in the language that they correspond to. So you're right, you just need to add the URL and then create a new localestring value in the nav object of the en.json file.

For now, I think that it's ok that we don't create translations for this page. When there isn't a page in another language the page shows a message saying that it's not been translated yet, which is ok. (I should probably add a new call to action there to make it clear that we want translations).

I'd say that you should go ahead and practice making another commit or two on this PR to change the thing I made a comment about and then add the link to the sidebar. Adding those two commits is as simple as git commit -am 'message' and git push. That'll update this PR.

erskingardner commented 3 months ago

Is this PR still on the go?

erskingardner commented 2 weeks ago

@boston-wine going to close this for now, feel free to reopen if you get back to it.

boston-wine commented 2 weeks ago

Hey Jeff, my B. Thought I answered this one earlier but totally fair to close for inactivity. When I can give it the attention deserved, I’ll reopen and submit anew 🫡

On Thu, Sep 12, 2024 at 3:03 AM, JeffG @.***(mailto:On Thu, Sep 12, 2024 at 3:03 AM, JeffG < wrote:

@.***(https://github.com/boston-wine) going to close this for now, feel free to reopen if you get back to it.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>