search

erskingardner / nostr-how

https://nostr.how
112 stars 51 forks source link

[WiP]: add Ukrainian language support #194

Closed dbarabashh closed 4 months ago

dbarabashh commented 4 months ago

Hey, I'm super excited that this project exists. It's really important for the community, and we need to support as many languages as possible so more people can get into Nostr.

In this PR, I followed the contribution guide. If I broke any rules, I'd be happy to fix them. I encountered some issues in this PR, which I've described here -> #193.

I want to take a few days to review everything again and ensure the translation is as accessible as possible for Ukrainian speakers. I'll let you know when this PR is ready to be merged into the main branch.

/cc @erskingardner

vercel[bot] commented 4 months ago

@tutizaraz is attempting to deploy a commit to the Jeff Gardner's projects Team on Vercel.

A member of the Team first needs to authorize it.

dbarabashh commented 4 months ago

@erskingardner why do we need both package-lock and pnpm-lock files? I guess we just need pnpm-lock

erskingardner commented 4 months ago

@erskingardner why do we need both package-lock and pnpm-lock files? I guess we just need pnpm-lock

We don't. the package-lock probably snuck in there at some point.... thanks for removing.

dbarabashh commented 4 months ago

@erskingardner this PR is ready for review