search

ertgrulll / advstory

An advanced, complete story viewer for Flutter. Has support for images, videos, custom widget contents, gestures, interceptors, listeners, manipulators and much more.
https://advstory.sourcekod.com
MIT License
41 stars 33 forks source link

[flutter web] add support for flutter web #1

Closed hmbenhaim closed 2 years ago

hmbenhaim commented 2 years ago

Add support to the package for flutter web Hi, this looks like an amazing package, I'm using a different package for stories, this one look much richer package, I'm working with flutter on the web.

My suggestion is to remove caching if kIsWeb is true I browsed a little bit in the source code of the package and I saw that the only thing that you depend on is the caching which is not currently available for the web, I just wondering if you can add a condition in case id kIsWeb true to get the image from the internet instead of the caching mechanism.

thank you

ertgrulll commented 2 years ago

Hello, thanks for your nice comments about package. I can add a condition for caching, but there will be other issues as well. Media sizes can also cause problems on the web. I'm planning to add web support, but it would be nice if you open a PR to make this possible sooner.

hmbenhaim commented 2 years ago

Ok I can test it on the web without caching I'll see if I can find a solution for all the rest of the issues that will come up.

ertgrulll commented 2 years ago

I've added this to the roadmap, I'm closing the issue. You can use discussions to discuss or advice anything about this feature.